UI: Use Qt::MiddleButton instead of deprecated Qt::MidButton#3810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UI: Use Qt::MiddleButton instead of deprecated Qt::MidButton
Motivation and Context
Qt::MidButton has been deprecated since Qt4 and removed in Qt6. It was replaced by Qt::MiddleButton, which is available in all versions of Qt5. Building against Qt 5.15+ will produce compiler warnings when using Qt::MidButton, and warnings are bad.
qt/qtbase@880cbf6
qt/qtbase@16e546e
How Has This Been Tested?
I compiled and ran OBS on Windows 10 Home 64-bit 2004 (Build 19041.630). I bound "Start Recording" to my mouse's middle button, and tested the hotkey, and it worked fine.
Types of changes
Checklist: