CI: Remove explicit LANGUAGE flags for cmake 3.19+#3753
Merged
jp9000 merged 1 commit intoobsproject:masterfrom Nov 21, 2020
PatTheMav:macos-cmake-fixes
Merged
CI: Remove explicit LANGUAGE flags for cmake 3.19+#3753jp9000 merged 1 commit intoobsproject:masterfrom PatTheMav:macos-cmake-fixes
jp9000 merged 1 commit intoobsproject:masterfrom
PatTheMav:macos-cmake-fixes
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Cmake directives to explicitly set the language of some plugins to
Con macOS which breaks most recentcmakeversions.Motivation and Context
Cmakemerged and released a change with version 3.19 that breaks building on macOS with our currentcmakerules.The change as explained in https://gitlab.kitware.com/cmake/cmake/-/merge_requests/4780 now sets the language flag explicitly when
LANGUAGEis set incmakerules. This leads to the switch-x cbeing added to calls toccorclangwhich then fails when the compiler meets an ObjectiveC file (as is the case inlibobsand some other plugins.According to one of
cmake's maintainers, the flag is supposed to explicitly set the source code language, not which compiler is preferred. This PR removes all instances of setting theLANGUAGEfor plugins that use ObjectiveC to enable compilation again.Note that
Cmakeis not part of macOS default or development distribution, so it has to be installed via Homebrew where 3.19 is the default version.How Has This Been Tested?
Types of changes
Checklist: