Skip to content

UI: Use non-native file dialog w/ Linux#3177

Merged
jp9000 merged 1 commit into
obsproject:masterfrom
cg2121:linux-filedialog
Jul 20, 2020
Merged

UI: Use non-native file dialog w/ Linux#3177
jp9000 merged 1 commit into
obsproject:masterfrom
cg2121:linux-filedialog

Conversation

@cg2121

@cg2121 cg2121 commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

Description

Fixes crash when using Linux browser when opening file dialog.

Motivation and Context

Workaround for obsproject/obs-browser#219 until the actual issue is solved.

How Has This Been Tested?

Opened file dialog to make they still work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX

RytoEX commented Jul 17, 2020

Copy link
Copy Markdown
Member

I thought there was a specific reason why we had decided this was a bad idea. @Gol-D-Ace or @kkartaltepe might remember.

@Gol-D-Ace

Gol-D-Ace commented Jul 18, 2020

Copy link
Copy Markdown
Collaborator

Doing this will reduce functionality on GTK.
Especially network shares will not be accessible anymore through the GUI.

I already had complaint's when doing that from users and reverted a different workaround.

On the other hand flatpak and co default to the qt widgets shrug

@cg2121

cg2121 commented Jul 18, 2020

Copy link
Copy Markdown
Contributor Author

This is just a stop-gap measure until the actual issue is fixed, so it is better than nothing.

@jp9000
jp9000 force-pushed the linux-filedialog branch 2 times, most recently from 78c9696 to d37c6fc Compare July 18, 2020 16:41
@jp9000
jp9000 force-pushed the linux-filedialog branch from d37c6fc to 762983b Compare July 18, 2020 16:49
@dodgepong

Copy link
Copy Markdown
Member

Doing this will reduce functionality on GTK.
Especially network shares will not be accessible anymore through the GUI.

If the choice is between "no browser sources on any Linux build" vs. "no ability to load files from network shares when using GTK" then I feel like the browser source should win out in this scenario, personally.

Would network shares still work with a manually-typed or copy/pasted path?

@jp9000

jp9000 commented Jul 18, 2020

Copy link
Copy Markdown
Member

Anyone have both Linux and access to network drives via Linux? If so could you pull and test to see if network paths work when manually typed in or pasted in to the dialog?

@kkartaltepe

Copy link
Copy Markdown
Collaborator

At least on my machine this doesnt affect any of the file dialogs (e.g. on gnome they still load the gnome file browsers)

@Gol-D-Ace

Copy link
Copy Markdown
Collaborator

Additional info:
Network shares should be still reachable from the mount location (on Ubuntu for example /run/user/$UID/gvfs)

Same with USB and other drives.

On the standard Ubuntu flavor this PR worked fine. Tomorrow I will try MATE.

@Gol-D-Ace

Copy link
Copy Markdown
Collaborator

Also working fine with Ubuntu MATE.
@kkartaltepe Do you have the qtconfig tool installed? It can override the default behavior (not sure if it can/should with this change though).

@kkartaltepe

Copy link
Copy Markdown
Collaborator

Both without qt config tool and with it the behavior was unchanged. After uninstalling nautilus the qt file picker showed up, and after reinstalling nautilus it stayed qt file picker... Even on master.

@jp9000
jp9000 merged commit aa0a652 into obsproject:master Jul 20, 2020
@cg2121
cg2121 deleted the linux-filedialog branch July 20, 2020 04:53
@nipafx

nipafx commented Jul 24, 2020

Copy link
Copy Markdown

Is it known when 25.0.9 will be released with this change?

@BloodyIron

Copy link
Copy Markdown

So with the merge of this, is this coming in a 25.0.9 release? And if so, when-ish?

@dodgepong

Copy link
Copy Markdown
Member

This will be officially released with the next major update (v26) in the next few weeks.

@BloodyIron

Copy link
Copy Markdown

That sucks :/ last major version release (v24) was Sept 2019. What good is having minor revision numbering if you can't even use it for something like this?

@dodgepong

Copy link
Copy Markdown
Member

...What? Last major release was v25 in March 2020.

@jp9000

jp9000 commented Jul 25, 2020

Copy link
Copy Markdown
Member

You make a lot of assumptions about what should or shouldn't be done or what goes in to a release, whether it be patch, minor, or major, especially considering how much as already been pushed to the master branch.

Please cease that discussion on our repositories. If you want to express your discontent, you can do it on discord or something. The repository is not the place for it.

@BloodyIron

Copy link
Copy Markdown

Did you miss the part where I said v24? Yes, v25 March 2020, v24 Sept 2019. Suggests to me that I'm waiting a long while (probably) for v26. Which is why I'm trying to make the case for a 25.0.9 for this fix. Again, why even have a numbering convention with 25.x.8 if the project isn't even going to use the x, or the minor minor release?

@BloodyIron

Copy link
Copy Markdown

Discord isn't a publicly indexed space. Github is. I don't see why discussion is unacceptable in this space, but whatever dudes. I've said my bit.

@RytoEX RytoEX mentioned this pull request Mar 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants