frontend: Cleanup Qt GuiPrivate linkage#12328
Merged
RytoEX merged 1 commit intoobsproject:masterfrom Dec 17, 2025
Merged
Conversation
6 tasks
tytan652
added
Linux
Chiitoo
reviewed
Jul 1, 2025
tytan652
force-pushed
the
no-qt-gui-private
branch
from
786b05c to
98ba790
Compare
Remove unneeded linkages and guard needed ones for Qt versions earlier than 6.9.0.
tytan652
force-pushed
the
no-qt-gui-private
branch
from
98ba790 to
26dfacb
Compare
Contributor
|
Looks good here now as well. Thank you! |
PatTheMav
approved these changes
Jul 16, 2025
Contributor
|
LGTM as well. Thanks for this! |
|
Would be nice if this is merged. Qt 6.10 has been released, and Arch Linux is already using it. |
13 tasks
RytoEX
approved these changes
Nov 11, 2025
6 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 16, 2025
While obs-studio itself is built with 'disable-werror' these days, '-Werror' in the the 'libobs.pc.in' causes other projects potentially unwanted build issues [1]. Also add the qt-6.10 patch to the git build, since the fix is still not merged upstream after half a year [2][3], and qt-6.10 has been out in the wilds for a while now. 1. https://bugs.gentoo.org/966311 2. obsproject/obs-studio#12321 3. obsproject/obs-studio#12328 Bug: https://bugs.gentoo.org/966311 Signed-off-by: Jimi Huotari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #12321
With Qt 6.9.0 and later, we no longer need to link with Qt::GuiPrivate.
There was also some unneeded linkage.
Motivation and Context
As documented in #12321, 6.10 change some behaviors around private targets. Avoiding linking as of 6.9.0 is the cleanest path.
How Has This Been Tested?
CI on my fork is green.
Types of changes
Checklist: