cmake: Adjust macOS SDK detection#12076
Merged
Merged
Conversation
Cherry picked from 8f1bcc1
Member
|
While I can merge this, we don't currently have any plans for further 31.0.x tags/releases. |
Contributor
Author
|
Thanks. If you do merge, I'd appreciate it. That way at least the tag my fork (glikely/obs-studio) points to a commit in the main repo instead of only my tree, which inspires confidence on anyone looking at the build deps. As it stands, obs-plugintemplate does not currently build and there isn't another workaround. |
RytoEX
approved these changes
Apr 25, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch fixes macos plugin builds against the 31.0.x obs-studio source tree. The cmake version 4 changes break the way obs-studio detects the version of the macos sdk that is installed. This PR fixes the problem by backporting the fix (8f1bcc1) from mainline obs-studio into the 31.0.x release branch.
More details of this issue can be found in this obs-plugintemplate issue:
obsproject/obs-plugintemplate#146
How Has This Been Tested?
Tested using the github actions for building this source tree, and also tested with a branch of obs-plugintemplate that shows the issue is fixed.
https://github.com/glikely/obs-plugintemplate/actions/runs/14618253470
Types of changes
Checklist: