Add obs-websocket 5.0.0 integration#340
Merged
Merged
Conversation
WizardCM
requested changes
Jan 1, 2022
WizardCM
left a comment
WizardCM
left a comment
Member
There was a problem hiding this comment.
This needs to respect ControlLevel. I do like the idea of supporting this though.
WizardCM
added
the
kind/enhancement
tt2468
force-pushed
the
feature/obs-websocket-lib
branch
2 times, most recently
from
January 9, 2022 22:46
9904eec to
599dab5
Compare
This adds integration into obs-websocket's new plugin API. The vendor name registered is `obs-browser`. Added vendor requests: - `emit_event` - Takes `event_name` and ?`event_data` parameters. Emits a custom event to all browser sources.
tt2468
force-pushed
the
feature/obs-websocket-lib
branch
from
January 9, 2022 22:54
599dab5 to
ab19104
Compare
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds integration into obs-websocket's new plugin API. The vendor name registered is
obs-browser.Vendor requests:
emit_event- Takesevent_nameand ?event_dataparameters. Emits a custom event to all browser sources.Motivation and Context
Integration between obs-browser and obs-websocket is a great proof of concept for our API and should serve as a great example for third-party plugin developers.
How Has This Been Tested?
Tested by sending a request to obs-websocket and listening for the event in a test HTML page.
Request:
Test HTML Page:
Result in dev tools:
Types of changes
Checklist: