Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support Check boxes and List Items in "1)"-style numbered lists #3402

Merged
merged 8 commits into from
Mar 30, 2025

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

In issue #3401, reported earlier today, I learned that it was possible to write numbered list items like this:

1) [ ] #task Task 1
    1) Sub-item 1
2) [ ] #task Task 2
    1) Sub-item 2

This teaches Tasks to support that format, and updates the documentation accordingly.

Note: In creating tests for this, I discovered an issue with how Obsidian parses nested, numbered list items - they must begin with 1. or 1).

I've logged it in https://forum.obsidian.md/t/incorrect-parsing-of-numbered-list-items-when-first-nested-item-number-is-not-1/98997

Motivation and Context

Fix #3401

How has this been tested?

  • New unit tests
  • Exploratory testing

Screenshots (if appropriate)

Checklist

Terms

@claremacrae claremacrae added the scope: parsing markdown See also 'scope: global filter' label Mar 30, 2025
@claremacrae claremacrae merged commit 7a4ccaf into main Mar 30, 2025
4 checks passed
@claremacrae claremacrae deleted the fix-numbered-list-with-paren branch March 30, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: parsing markdown See also 'scope: global filter'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unexpected failure to create a list item from line" warning when parsing "1)" style numbered list
1 participant