fix: Stable group by function task.urgency order
#3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By imposing an arbitrary 5 decimal places of precision if the 'group by function' expression returns a non-integer numeric value. Fixes #3371
with precision not specified...
claremacrae
changed the title
group by function task.urgencygroup by function task.urgency order
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)docs- improvements to any documentation content for users)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Description
If custom group labels are floating point numbers, round them to a fixed 5 decimal places, to prevent observed problems of the sort order appearing random, if floating point group labels have different numbers of decimal places.
Motivation and Context
Fix #3371:
How has this been tested?
Screenshots (if appropriate)
Checklist
yarn run lint.Terms