refactor: Remove need to construct temporary Task objects #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claremacrae
added
type: internal
|
ilandikov
reviewed
Mar 24, 2025
ilandikov
reviewed
Mar 24, 2025
ilandikov
reviewed
Mar 24, 2025
| @@ -127,18 +127,28 @@ export class TaskLineRenderer { | |||
| * @note Output is based on the {@link DefaultTaskSerializer}'s format, with default (emoji) symbols | |||
| * @param task The task to be rendered. | |||
| * @param taskIndex Task's index in the list. This affects `data-line` data attributes of the list item. | |||
| * @param isTaskInQueryFile | |||
There was a problem hiding this comment.
I wonder whether this jsdoc is still valid since now function
public async renderTaskLine({
task,
taskIndex,
isTaskInQueryFile,
isFilenameUnique,
}: {
task: Task;
taskIndex: number;
isTaskInQueryFile: boolean;
isFilenameUnique?: boolean;
}): Promise<HTMLLIElement> {}has only one parameter: {task, taskIndex, isTaskInQueryFile, isFilenameUnique } with 4 properties...
There was a problem hiding this comment.
I wondered the same thing, but neither WebStorm nor SonarLine/Qube is complaining...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Done by pairing with @ilandikov.
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Description
This refactors the fix for #3297
Motivation and Context
The goal was to remove the need to create new
Taskobjects during rendering.How has this been tested?
resources/sample_vaults/Tasks-Demo/Test Data/internal_heading_links.mdScreenshots (if appropriate)
Checklist
yarn run lint.Terms