Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ListItem.fromListItemLine() now correctly returns null #3390

Conversation

ilandikov
Copy link
Collaborator

Types of changes

Done by pairing with @claremacrae

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Motivation and Context

  • code improvement

How has this been tested?

  • unit tests

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@ilandikov ilandikov changed the title Refactor null from list item line refactor: ListItem.fromListItemLine() now correctly returns null Mar 24, 2025
@ilandikov ilandikov added the type: internal Only regards development or contributing label Mar 24, 2025
@claremacrae claremacrae merged commit e319f25 into obsidian-tasks-group:main Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants