Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Auto-Suggest for 'NON_TASK' statuses #3384

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

If the user has defined the status symbol as NON_TASK the line should be ignored by the Tasks auto-suggest feature.

Motivation and Context

Fix #1509.

How has this been tested?

  • New unit test (and confirmed that this failed before the fix)
  • Exploratory testing

Screenshots (if appropriate)

Checklist

Terms

@claremacrae claremacrae added the scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes label Mar 17, 2025
@claremacrae claremacrae changed the title fix: Don't show Auto-Suggest for 'NON_TASK' status types fix: Prevent Auto-Suggest for 'NON_TASK' statuses Mar 17, 2025
@claremacrae claremacrae merged commit 366a8a1 into main Mar 17, 2025
4 checks passed
@claremacrae claremacrae deleted the issue-1509-no-suggest-on-NON_TASK branch March 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: auto-suggest The pop-up menu that helps with editing tasks directly in markdown notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Auto-Suggest popup only when status type is not NON_TASK
1 participant