Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent use of missing properties in placeholders (#3249) #3380

Merged
merged 1 commit into from
Mar 14, 2025
Merged

fix: Prevent use of missing properties in placeholders (#3249) #3380

merged 1 commit into from
Mar 14, 2025

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Instead of using 'null' for invalid values, which is never what the user intended, report an error.

Motivation and Context

Fix #3249

How has this been tested?

  • Updating existing tests
  • Exploratory testing

Screenshots (if appropriate)

image

Checklist

Terms

@claremacrae
fix: Prevent use of missing properties in placeholders (#3249)
7ff9d08 
Instead of using 'null' for invalid values, which is never what the
user intended, report an error.

Fixes #3249
@claremacrae claremacrae added scope: filters Additions and modifications to the search filters scope: scripting Issues to do with custom filters, custom sorting and similar labels Mar 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@claremacrae claremacrae merged commit ac36806 into main Mar 14, 2025
4 checks passed
@claremacrae claremacrae deleted the prevent-unused-placeholders-in-placeholders branch March 14, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: filters Additions and modifications to the search filters scope: scripting Issues to do with custom filters, custom sorting and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholders that use non-existent properties silently work, giving useless 'null' query values
1 participant
@claremacrae