refactor: Finish implementing ListItem.fromListItemLine() #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
claremacrae
commented
Mar 17, 2025
| originalMarkdown: string, | ||
| parent: ListItem | null, | ||
| taskLocation: TaskLocation, | ||
| ): ListItem | null { |
There was a problem hiding this comment.
@ilandikov I've realised that I named this PR incorrectly...
I had forgotten that we still needed to change ListItem.fromListItemLine() to return null if the line wasn't actually a list item...
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Done by pairing with @ilandikov.
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
ListItem.fromListItemLine()now returnsnullif the given line is not a list item.This makes it consistent with the corresponding method on
Taskand fixes a failing test.Motivation and Context
How has this been tested?
Unit tests.
Checklist
yarn run lint.Terms