You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
Description
Add ListItem.fromListItemLine() method, similar to Task.fromLine()
Use ListItem.fromListItemLine() instead of the constructor
Use destructured parameter in ListItem constructor similar to Task
Motivation and Context
Make ListItem shape and patters similar to Task
This is in preparation for allowing ListItem.fromListItemLine() to return null if given a non-list-item line.
How has this been tested?
Unit tests
Checklist
My code follows the code style of this project and passes yarn run lint.
Make ListItem constructor private and use ListItem.fromListItemLine() instead
I'm not seeing that change in the diffs... It looks public still to me.
Having said that, the Tasks constructor is also public, and that works fine.
So I guess making it protected was a useful temporary step to confirm we had caught all cases - and it's fine now that it's public...
Make ListItem constructor private and use ListItem.fromListItemLine() instead
I'm not seeing that change in the diffs... It looks public still to me.
Having said that, the Tasks constructor is also public, and that works fine. So I guess making it protected was a useful temporary step to confirm we had caught all cases - and it's fine now that it's public...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Done by pairing with @claremacrae
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
ListItem.fromListItemLine()method, similar toTask.fromLine()ListItem.fromListItemLine()instead of the constructorListItemconstructor similar toTaskMotivation and Context
ListItemshape and patters similar toTaskThis is in preparation for allowing
ListItem.fromListItemLine()to returnnullif given a non-list-item line.How has this been tested?
Checklist
yarn run lint.Terms