fix: Only execute searches after Obsidian finishes loading #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may improve start-up time, when Obsidian opens with notes containing Tasks search results loaded, in Reading mode or Live Preview. This fixed use of a "CodeScript Toolkit" startup script inside notes that were already open in Reading mode when Obsidian was starting up. Thanks to @mnaoumov for pointing this out. Co-Authored-By: Michael Naumov <[email protected]>
claremacrae
added
the
scope: performance issues
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Description
Only execute searches after Obsidian finishes loading.
Benefits:
Thanks to @mnaoumov for pointing this out.
Motivation and Context
See above
How has this been tested?
Launching Obsidian with Tasks searches already open, and confirming the results are still rendered correctly.
Checklist
yarn run lint.Terms