fix: Reinstate date picker on iPhone - week starts on Monday #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ca8fe6.
This reverts commit 3a34bab.
This reverts commit 6133316.
This reverts commit 9752a15.
This fixes #3341. Note that the date picker in Reading Mode and Tasks query Results remains hard-coded to start on Monday, because it turned out that the code added in #3259 to address #3239 works well on Android, but gave an error on iPhone (and probably iPad too). Thanks to @esm7 for suggesting the fix. Co-Authored-By: esm7 <[email protected]>
claremacrae
added
display: reading mode
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)docs- improvements to any documentation content for users)Description
mainNote that the date picker in Reading Mode and Tasks query Results remains hard-coded to start on Monday, because it turned out that the code added in #3259 to address #3239 works well on Android, but gave an error on iPhone (and probably iPad too).
Thanks to @esm7 for suggesting the fix.
Motivation and Context
This fixes #3341.
How has this been tested?
On my iPhone 13 Pro Max - with iOS 17.1.1.
Checklist
yarn run lint.Terms