Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Toggle non-task checkbox lines in tree view #3338

Merged

Conversation

ilandikov
Copy link
Collaborator

@ilandikov ilandikov commented Feb 18, 2025

Types of changes

Done by pairing with @claremacrae

Changes visible to users:

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

  • in task query results with show tree, child checkbox lines without the global filter now get displayed with a checkbox and these are toggle able using same behaviour as obsidian

Motivation and Context

How has this been tested?

  • unit tests + new manual smoke test

Screenshots

With this markdown - and a global filter #task:

-  [ ] #task task parent
    - [ ] #task task child
    - [ ] non-task child
    - [x] non-task child status x
    - list item child

```tasks
filename includes {{query.file.filename}}
show tree
```

image

Checklist

Terms

@ilandikov ilandikov added scope: rendering of tasks How the plugin displays tasks, including search results (except CSS issues) scope: sub-tasks and super-tasks nested/parent/child: controlling their display, filtering them, and similar labels Feb 18, 2025
@claremacrae claremacrae changed the title fix: toggle list item checkboxes fix: non-task checkbox lines can be toggled in tree view Feb 18, 2025
@claremacrae
Copy link
Collaborator

I've added a screenshot.

@claremacrae claremacrae changed the title fix: non-task checkbox lines can be toggled in tree view fix: Toggle non-task checkbox lines in tree view Feb 18, 2025
@claremacrae claremacrae merged commit dbd8bda into obsidian-tasks-group:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: rendering of tasks How the plugin displays tasks, including search results (except CSS issues) scope: sub-tasks and super-tasks nested/parent/child: controlling their display, filtering them, and similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'show tree' does not render non-task checkboxes
2 participants