contrib, chore: Improvements to setting up a build environment, mostly for vscode and windows. #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 'Check esbuild.config.mjs' test, which would break when the repo was cloned on windows due it asserting on file contents.
The project no longer builds with node 16 due to dependency requirements. 18 still works fine though. This also updates the contribution documents so contributors know where to check to get the correct node version.
- Jest allows running tests and seeing their results right in vscode - svelte allows language understanding for svelte files - scss for scss intellisense - yarn for running yarn scripts from the UI An additional setting is included that enables ts features of the svelte plugin.
|
claremacrae
changed the title
claremacrae
approved these changes
Feb 17, 2025
claremacrae
approved these changes
Feb 18, 2025
|
Thanks @EanLombardo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
feat- non-breaking change which adds functionality)feat!!orfix!!- fix or feature that would cause existing functionality to not work as expected)fix- non-breaking change which fixes an issue)docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)contrib- any improvements to documentation content for contributors - see Contributing to Tasks)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Description
General improvements for contributors using windows and vscode.
Motivation and Context
This test is currently broken when the repo is cloned on windows, due to CLRF line conversion.
When setting up my build environment the recommended and configured minimum node version was incompatible with some dependencies.
These vscode extensions are very useful for this project. All including them does is notify the user when the project is opened for the first time, that these plugins might be useful.
How has this been tested?
The project builds and tests successfully on my machine now.
Screenshots (if appropriate)
Checklist
yarn run lint.Terms