chore: Run pre-commit checks on .svelte and json test data files #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--findRelatedTests does not detect changes in imported json files, and we have had cases of commits with accidental broken tests, because lefthook did not run the affected tests pre-commit. The options seemed to be 1. Write and maintain a .js script to manually detect which tests need to be run 2. On the rare occasions when we change the JSON test data, just run all the tests. See also my StackOverflow answer about this: https://stackoverflow.com/a/79437866/104370
|
|
Nice improvement, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Internal changes:
chore- examples include GitHub Actions, issue templates)Description
Make the
lefthookchecks run all tests and lint all files, as appropriate, when*.svelteandtests/Obsidian/__test_data__/*.jsonare committed.I have been unable to find a way to run the tests selectively, so have opted for just running all tests when those files are edited.
I wrote the technique up here:
Motivation and Context
@ilandikov and I have both been tripped up by the pre-commit checks:
How has this been tested?
By trying to commit broken files, and confirming that the commit failed.
Checklist
yarn run lint.Terms