fix: detect Chinese language and refine the translation #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: resolve bug with Chinese translation not displaying refactor: optimize Chinese translations
|
claremacrae
added
the
scope: internationalisation
claremacrae
approved these changes
Feb 11, 2025
| @@ -12,6 +12,7 @@ module.exports = { | |||
| '^.+\\.ts$': 'ts-jest', | |||
| }, | |||
| moduleFileExtensions: ['js', 'ts', 'svelte'], | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
For my own education, what is this for please?
| import en from './locales/en.json'; | ||
| import zh_cn from './locales/zh_cn.json'; | ||
|
|
||
| let isInitialized = false; | ||
|
|
||
| // Get Obsidian language settings | ||
| const getObsidianLanguage = (): string => { | ||
| return localStorage.getItem('language')?.toLowerCase() || 'en'; |
There was a problem hiding this comment.
What's the thinking behind toLowerCase()?
claremacrae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Description
i18next-browser-languagedetectordependencyMotivation and Context
The new Chinese translation of 7.15.0 is not effective. · Issue #3322 · obsidian-tasks-group/obsidian-tasks
How has this been tested?
I used version 1.8.4 of Obsidian, and tested language switching on both macOS and Windows environments, and it works well.
Screenshots (if appropriate)
Checklist
yarn run lint.Terms