refactor: Rename 'tasks_query_*' properties to 'TQ_*' #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasks_query_show_scheduled_date and similar turned out to be just too long on mobile phones, even after using CSS to widen the property names.
tasks_query_show_scheduled_date and similar turned out to be just too long on mobile phones, even after using CSS to widen the property names.
tasks_query_show_scheduled_date and similar turned out to be just too long on mobile phones, even after using CSS to widen the property names.
claremacrae
added
the
scope: frontmatter
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
I hummed and hahed on the prefix for this, eventually settling on
refactorbecause it is changing a facility that is not yet released.Changes visible to users:
docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Description
Shorten the Query File Defaults property names:
tasks_query_*TQ_*Motivation and Context
Although I prefer the longer, more descriptive names, I found them to be just too wide when looking at the File Properties view on a fairly large iPhone screen.
How has this been tested?
Screenshots (if appropriate)
Checklist
yarn run lint.Terms