-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detect changes in query file path and query properties #3281
Conversation
If a new TasksFile is supplied, the query needs to be regenerated.
This fixes an unreported bug that placeholders where not updated when the file was renamed. It also fixes #899, which was much more minor.
…roved.md For later embedding in the user docs.
|
I just came looking for the possibility to do |
Hi @holroy.... Current statusyes, that's right. The release script updates the version number, as it's only at that point I know if it's going to be a minor, major or breaking version number. There's a lot to do before the next release, so I don't know when it will be. Request for feedbackHowever, I do have a favour to ask of you. Would you be willing to try out a build of Tasks with this code in for a few days - and give me feedback on the docs and the behaviour please? I am confident enough in the code to be using it in my own vault, and it is working pretty well. Getting the latest buildThe build is here: The files in the build are described here: Please note any feedback as comments on this PR - and also, if you have any example uses that would be good for the docs, that would be welcome too. |
In #3281 I made the query refresh when its path changes, to update the effects of any placeholders.
Types of changes
Changes visible to users:
fix
- non-breaking change which fixes an issue)docs
- improvements to any documentation content for users)vault
- improvements to the Tasks-Demo sample vault)Internal changes:
test
- additions and improvements to unit tests and the smoke tests)Description
Summary: This is all about making the following features releasable, by fixing bugs in the initial implementation and adding documentation:
Detail:
query.file.hasProperty()
andquery.file.property()
Motivation and Context
This builds on the following PRs:
They enabled queries to access
query.file.hasProperty()
andquery.file.property()
, but with the major limitation that the query file had to be re-opened for the changes to take effect.How has this been tested?
Screenshots (if appropriate)
Video coming soon
Checklist
yarn run lint
.Terms