fix: date picker in Reading mode & searches honours first day of week #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
esm7
changed the title
claremacrae
changed the title
claremacrae
changed the title
claremacrae
changed the title
|
Thank you - I've edited the description to say that it fixes #3239. |
claremacrae
reviewed
Jan 2, 2025
|
Tested on macOS 15.1.1 (24B2091)
The date-picker in Reading view and Tasks search results then switched to starting the week on Sunday! |
claremacrae
added
the
scope: user interface
claremacrae
approved these changes
Jan 3, 2025
|
Many thanks for doing this @esm7! 🎉 ❤️ |
|
Many thanks for the date picker, it's the most important feature I had no clue I needed so much! ❤️ |
8 tasks
Closed
8 tasks
claremacrae
added a commit
that referenced
this pull request
Feb 22, 2025
This fixes #3341. Note that the date picker in Reading Mode and Tasks query Results remains hard-coded to start on Monday, because it turned out that the code added in #3259 to address #3239 works well on Android, but gave an error on iPhone (and probably iPad too). Thanks to @esm7 for suggesting the fix. Co-Authored-By: esm7 <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Description
The new date picker is an awesome, super useful addition. But the way it was introduced, it was hard-coded for the week to start on Monday, which is not the case for many users. This fix tries to query the system's locale for the correct day of the week, and uses Monday only if no such information is available.
Motivation and Context
As described above.
Fixes #3239.
How has this been tested?
Tested on the latest Obsidian Desktop and Android app.
Screenshots (if appropriate)
Checklist
yarn run lint.Terms