generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow multi-line properties in {{query.file.property('...')}} #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y - "many of one"
…f one" refactoring
…opertyWithValue()
…opertyWithValue()
…ryFromPropertyWithValue()
…roperties This removes the spaces that were retained before end-of-line placeholder comments, that were previously present but undocumented.
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: filters
Additions and modifications to the search filters
scope: scripting
Issues to do with custom filters, custom sorting and similar
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix
- non-breaking change which fixes an issue)Internal changes:
test
- additions and improvements to unit tests and the smoke tests)Description
This fixes one of the limitations from PR #3242 - the following now works:
Note that continuation lines are not supported in multi-line properties, when they are used in placeholders.
Motivation and Context
Getting closer to releasing access to
query.file.property()
andquery.file.hasProperty()
to users...See:
How has this been tested?
Screenshots (if appropriate)
Consider the following demo sample markdown note.
I have 3 Tasks searches, and they differ only in the
happens
date filter: I have a bunch of standard instructions that I want to use in all 3 searches.Now, I can put all my standard instructions in a multi-line
common_instructions
property value, and embed its value as a placeholder in each of the 3 searches 🎉 :Here are the search results:
Checklist
yarn run lint
.Terms