我也是，翻译无效，是什么问题？？？

Translation posted by @claremacrae

Me too, the translation is invalid, what's the problem? ? ?

Thank you for logging this here, @dangehub.

How it is supposed to work

The code that is supposed to detect the user's language is line 12 here:

LanguageDetector comes from i18next-browser-languagedetector.

What might be going wrong

So I think possible causes might be:

• Something about the naming of languages in Tasks is not consistent with conventions in LanguageDetector
• I don't remember where I got the zh_cn naming from, that is in the Tasks source code - perhaps that is not standard?
• Naming of languages is not sufficient and I am not wiring up LanguageDetector correctly...

Yes, looking at i18next-browser-languagedetector it does seem that detection is not automatic...

According to https://www.moritzjung.dev/obsidian-stats/, the other two Obsidian plugins that use i18next-browser-languagedetector are:

• https://www.moritzjung.dev/obsidian-stats/plugins/awesome-brain-manager/
  • MIT licence
• https://www.moritzjung.dev/obsidian-stats/plugins/rpg-manager/
  • MIT licence

With those licenses being compatible with Tasks, I can look at the code of both of them, to see how they work...

https://github.com/carlonicora/obsidian-rpg-manager/blob/2fdc0599c7f9cc15844e90dd710beaef403e48f0/src/services/InternationalisationService.ts#L11

https://github.com/JuckZ/awesome-brain-manager/blob/6c1643b7b1068ae1da1b172b5ceff8db0c32ca9e/src/i18n.ts#L40

According to https://www.moritzjung.dev/obsidian-stats/, the other two Obsidian plugins that use i18next-browser-languagedetector are:

• https://www.moritzjung.dev/obsidian-stats/plugins/awesome-brain-manager/

  • MIT licence

• https://www.moritzjung.dev/obsidian-stats/plugins/rpg-manager/

  • MIT licence

With those licenses being compatible with Tasks, I can look at the code of both of them, to see how they work...

https://github.com/carlonicora/obsidian-rpg-manager/blob/2fdc0599c7f9cc15844e90dd710beaef403e48f0/src/services/InternationalisationService.ts#L11

https://github.com/JuckZ/awesome-brain-manager/blob/6c1643b7b1068ae1da1b172b5ceff8db0c32ca9e/src/i18n.ts#L40

I believe the problem is coming from the place you mentioned.

I added console code to observe the detected language code

console.log('Detected Language:', languageDetector.detect());

I have made some attempts, but still failed, I hope you can solve this problem.

By the way, I kindly ask for a bit of time before you release the fix update. I've just noticed that there are still many areas in the Chinese translation that need improvement. I will strive to push out a better version within one to two hours.

Thank you.

There is a separate question about whether Tasks should honour the language in Obsidian's General settings. Currently, Tasks does not detect the Obsidian language setting, and from your research, it looks like LanguageDetector does not either, unsurprisingly.

I think Tasks should honour the Obsidian settings, but that it should be changed in a separate step from this issue which is about fixing the automatic language detection.

By the way, I kindly ask for a bit of time before you release the fix update. I've just noticed that there are still many areas in the Chinese translation that need improvement. I will strive to push out a better version within one to two hours.

I am busy for several hours anyway - I do have other things to do than working on Tasks! 😄

By the way, I kindly ask for a bit of time before you release the fix update. I've just noticed that there are still many areas in the Chinese translation that need improvement. I will strive to push out a better version within one to two hours.

I am busy for several hours anyway - I do have other things to do than working on Tasks! 😄

I have found the solution, and I will submit the fix for this issue along with the improvement of the Chinese translation.

In short, it's an issue with the language codes. Additionally, there's another problem: if you use languageDetector, when a user manually switches the language in Obsidian, due to localdata cache, tasks won't immediately switch languages. This might require more extensive changes.

For specific details, please check the PR when I submit it soon.

Goal for this Issue

The definition of success for this issue is that if the user's computer is set to Chinese, then the Tasks plugin should auto-detect the language and show the settings in Chinese.

Possible fix

@dangehub, if I understand correctly, the following edit does recognise the language is Chinese, so perhaps I should just go ahead and make that change? What do you think?

If I modify this line of code and rebuild plugin , tasks will become in Chinese and cannot be switched back to English.

original code:

                resources: {
                    en: { translation: en },
                    zh_cn: { translation: zh_cn },

modified code:

                resources: {
                    en: { translation: en },
                    'zh-CN': { translation: zh_cn },

I have found the solution, and I will submit the fix for this issue along with the improvement of the Chinese translation.

Great!

Additionally, there's another problem: if you use languageDetector, when a user manually switches the language in Obsidian, due to localdata cache, tasks won't immediately switch languages. This might require more extensive changes.

I hadn't seen that message when I wrote the reply above.

Yes you are right that the above will require more extensive changes, as the whole Tasks plugin code was not written to reload when things like settings change, so it definitely wouldn't refresh when the language changes...

Feel free to log a separate request that Tasks should honour the Obsidian language setting at start-up and override the LanguageDetector value.

This is now released in Tasks 7.15.1.

Many thanks @dangehub!

目前已在 Tasks 7.15.1 中发布。

非常感谢@dangehub！