Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading mode Date picker (on task query) does not respect first day of week on iPhone (unlike the Edit Task modal date picker, which does) #3239

Open
4 of 8 tasks
arcegabriel opened this issue Dec 13, 2024 · 5 comments · Fixed by #3259
Open
4 of 8 tasks

Reading mode Date picker (on task query) does not respect first day of week on iPhone (unlike the Edit Task modal date picker, which does) #3239

arcegabriel opened this issue Dec 13, 2024 · 5 comments · Fixed by #3259
Labels
display: reading mode Issues referring to Obsidian's Reading Mode or Reading View scope: user interface UI other than Edit task modal, e.g. context menus, date picker type: bug Something isn't working

Comments

@arcegabriel
Copy link

⚠️ Check issue is valid.

⚠️ Check that this issue hasn't been reported before.

Steps to reproduce

  1. Create a task with due date
  2. Create a task query to see task
  3. On query, click on due date to view date picker
  4. Date picker starts on Monday
  5. Edit task with Task Modal, change due date. Date picker starts on Sunday (which is my default)

Expected Behavior

Date Picker aligns with task modal (and obsidian calendar)

Current behaviour

Date picker starts on Monday regardless

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

1.7.7

Tasks Plugin Version

7.14.0

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

No response
@arcegabriel arcegabriel added the type: bug Something isn't working label Dec 13, 2024
@claremacrae
Copy link
Collaborator

Thank you for logging this.

Could you please explain what “like task modal” means in the description?

@claremacrae claremacrae added the question Further information is requested label Dec 14, 2024
@claremacrae
Copy link
Collaborator

Ohhhh. I see now. Thank you.
I had forgotten that the two date pickers are implemented differently.

@claremacrae claremacrae removed the question Further information is requested label Dec 14, 2024
@claremacrae claremacrae changed the title Date picker on task query does not respect first day of week (like task modal) Date picker on task query does not respect first day of week (unlike the Edit Task modal date picker, which does) Dec 14, 2024
@claremacrae
Copy link
Collaborator

I’ve edited the title slightly, to match my understanding.

@claremacrae
Copy link
Collaborator

Lines 29 here is why the Reading Mode date-picker always starts on Monday:

obsidian-tasks/src/ui/Menus/DatePicker.ts

Lines 23 to 31 in fb324a4

const fp = flatpickr(parentElement, {
defaultDate: currentValue ? currentValue.format('YYYY-MM-DD') : new Date(),
disableMobile: true,
enableTime: false, // Optional: Enable time picker
dateFormat: 'Y-m-d', // Adjust the date and time format as needed
locale: {
firstDayOfWeek: 1, // Sets Monday as the first day of the week
},
onClose: async (selectedDates, _dateStr, instance) => {

Without that line, it always starts on Sunday, even if the Locale says the week starts on Monday.

So that line cannot be removed - instead someone needs to figure out how to make flatpickr automatically set the start of the week correctly.

@claremacrae claremacrae added display: reading mode Issues referring to Obsidian's Reading Mode or Reading View scope: user interface UI other than Edit task modal, e.g. context menus, date picker labels Dec 14, 2024
@claremacrae claremacrae changed the title Date picker on task query does not respect first day of week (unlike the Edit Task modal date picker, which does) Reading mode Date picker (on task query) does not respect first day of week (unlike the Edit Task modal date picker, which does) Dec 14, 2024
@claremacrae claremacrae mentioned this issue Jan 2, 2025
Merged
7 tasks
@claremacrae claremacrae added the status: next release Should be part of the next release label Jan 3, 2025
@claremacrae claremacrae mentioned this issue Jan 7, 2025
Closed
8 tasks
claremacrae added a commit that referenced this issue Feb 22, 2025
@claremacrae @esm7
fix: Reinstate date picker on iPhone - week starts on Monday
62c3061 
This fixes #3341.

Note that the date picker in Reading Mode and Tasks query Results
remains hard-coded to start on Monday, because it turned out
that the code added in #3259 to address #3239 works well on Android,
but gave an error on iPhone (and probably iPad too).

Thanks to @esm7 for suggesting the fix.

Co-Authored-By: esm7 <[email protected]>
@claremacrae claremacrae mentioned this issue Feb 22, 2025
Merged
8 tasks
@claremacrae claremacrae changed the title Reading mode Date picker (on task query) does not respect first day of week (unlike the Edit Task modal date picker, which does) Reading mode Date picker (on task query) does not respect first day of week on iPhone (unlike the Edit Task modal date picker, which does) Feb 22, 2025
@claremacrae
Copy link
Collaborator

I'm re-opening this, and have renamed it to indicate that the problem now only occurs on iPhone, and likely iPad too.

@claremacrae claremacrae reopened this Feb 22, 2025
@claremacrae claremacrae removed the status: next release Should be part of the next release label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
display: reading mode Issues referring to Obsidian's Reading Mode or Reading View scope: user interface UI other than Edit task modal, e.g. context menus, date picker type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: date picker in Reading mode & searches honours first day of week esm7/obsidian-tasks
2 participants
@claremacrae @arcegabriel