group segments by z #764
Closed
group segments by z #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
Let me share one experiment here, even if it's not super conclusive. In the image below, we have one path per z-line and a svg:use for each segment, with a specific stroke-dasharray to tell where the ink should go: diff --git a/src/marks/line.js b/src/marks/line.js
index 7816216..38949ae 100644
--- a/src/marks/line.js
+++ b/src/marks/line.js
@@ -39,17 +39,29 @@ export class Line extends Mark {
.call(g => g.selectAll()
.data(groupIndex(I, [X, Y], channels))
.join("g")
+ .call(g => g.append("path")
+ .attr("d", segments => shapeLine()
+ .curve(this.curve)
+ .defined(i => i >= 0)
+ .x(i => X[i])
+ .y(i => Y[i])
+ (segments.flat()))
+ .attr("id", function(segments) {
+ const id = "pu" + segments.flat().join("-"); // TODO: unique id generator
+ const href = `#${id}`;
+ // TODO: proper measurement of the correct cover start and end
+ const cover = this.getTotalLength() / segments.length;
+ segments.forEach((segment, count) => Object.assign(segment, {cover, count, href}));
+ return id;
+ })
+ )
.selectAll()
.data(segments => segments)
- .join("path")
+ .join("use")
+ .attr("href", ({href}) => href)
+ .attr("stroke-dasharray", ({count, cover}) => [0, count * cover, cover, 100000])
.call(applyDirectStyles, this)
.call(applyGroupedChannelStyles, this, channels)
- .call(applyGroupedMarkers, this, channels)
- .attr("d", shapeLine()
- .curve(this.curve)
- .defined(i => i >= 0)
- .x(i => X[i])
- .y(i => Y[i])))
+ .call(applyGroupedMarkers, this, channels))
.node();
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes groupIndex return a nested collection of indices per z. In short, it creates segmented lines and areas as a svg:g for each line, containing all the path segments, rather than flattening all the segments together. See #761 (comment) for context.
As a consequence, obviously, is that each line (in the "normal" case) is wrapped in a svg:g.
This allows an easier manipulation of lines and areas with D3 or with vector graphics software, and also makes it easier to create alternative grouped marks.