Skip to content

only truncate the long visible text, not the title #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbostock merged 1 commit into from
Nov 1, 2023
Merged

only truncate the long visible text, not the title #1913

mbostock merged 1 commit into from
Nov 1, 2023

Conversation

@Fil
Copy link
Contributor

@Fil Fil commented Nov 1, 2023

(bug reported and fixed by @mootari)

before after
Capture d’écran 2023-11-01 à 14 36 43 Capture d’écran 2023-11-01 à 14 33 43

@Fil Fil requested review from mbostock and mootari November 1, 2023 13:37
@mbostock mbostock merged commit 99c8995 into main Nov 1, 2023
@mbostock mbostock deleted the fil/tip-title-truncate branch November 1, 2023 17:13
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
@Fil @chaichontat
only truncate the long visible text, not the title (observablehq#1913)
0013dbb
@x-way x-way mentioned this pull request Jul 3, 2024
Closed
This was referenced Jul 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 20, 2024
Closed
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbostock mbostock mbostock approved these changes

@mootari mootari mootari approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fil @mbostock @mootari