test tip for primitive data #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yes, similar to what happens with a raster mark with data = volcano.values (or rather, when #1634 is fixed). |
Fil
approved these changes
May 27, 2023
mbostock
force-pushed
the
mbostock/fix-dotx-tip-title
branch
from
1cc42a0 to
087b340
Compare
This was referenced May 28, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initially surprised me, but now I think it might be desirable/acceptable: if the mark has primitive data, we consider it to be “textual”, and hence default the title channel to identity. And hence the tip displays the data rather than the channels. If the mark has primitive data, then maybe it’s unlikely that the channels would show anything else interesting? So this might be a reasonable default. But I can’t think of a way to opt-out of this behavior and show all channels, either, since the title option isn’t visible to the derived tip—it can only see the data and the channels…