facet warning logic & wording #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fil
commented
Jul 28, 2022
Fil
commented
- Compare the lengths of the arrayified versions of facet.data and mark.data.
- Remove spurious svg
- Wording based on suggestion by @mbostock (but simpler) (?).
mbostock
reviewed
Jul 28, 2022
Fil
added a commit
that referenced
this pull request
Jul 28, 2022
Not sure how to remove the warning from the yarn test log—but this doesn't seem to be blocking
mkfreeman
added a commit
that referenced
this pull request
Jul 28, 2022
* Add warning when facet data doesn't match mark data * Adjust for tests, add warning svg * Run prettier * Renamed files, improved conditions for warning * Fix typo * Use arrayify to check the length Co-authored-by: Mike Bostock <[email protected]> * Update warning language used. Co-authored-by: Mike Bostock <[email protected]> * Remove facet_warning.svg file * facet warning logic & wording (#1015) * logic & wording * remove fcet_warning.svg * An arguably better test/example plot. * fix my mistake (ref #1015 (review)) Not sure how to remove the warning from the yarn test log—but this doesn't seem to be blocking * arrayify(mark.data)?.length * facetData.length * revert wording Co-authored-by: Mike Bostock <[email protected]> Co-authored-by: Philippe Rivière <[email protected]>
backend-devloper
pushed a commit
to backend-devloper/plot
that referenced
this pull request
Nov 24, 2023
* Add warning when facet data doesn't match mark data * Adjust for tests, add warning svg * Run prettier * Renamed files, improved conditions for warning * Fix typo * Use arrayify to check the length Co-authored-by: Mike Bostock <[email protected]> * Update warning language used. Co-authored-by: Mike Bostock <[email protected]> * Remove facet_warning.svg file * facet warning logic & wording (#1015) * logic & wording * remove fcet_warning.svg * An arguably better test/example plot. * fix my mistake (ref observablehq/plot#1015 (review)) Not sure how to remove the warning from the yarn test log—but this doesn't seem to be blocking * arrayify(mark.data)?.length * facetData.length * revert wording Co-authored-by: Mike Bostock <[email protected]> Co-authored-by: Philippe Rivière <[email protected]>
tigrevol8888
added a commit
to tigrevol8888/plot
that referenced
this pull request
Jul 5, 2024
* Add warning when facet data doesn't match mark data * Adjust for tests, add warning svg * Run prettier * Renamed files, improved conditions for warning * Fix typo * Use arrayify to check the length Co-authored-by: Mike Bostock <[email protected]> * Update warning language used. Co-authored-by: Mike Bostock <[email protected]> * Remove facet_warning.svg file * facet warning logic & wording (#1015) * logic & wording * remove fcet_warning.svg * An arguably better test/example plot. * fix my mistake (ref observablehq/plot#1015 (review)) Not sure how to remove the warning from the yarn test log—but this doesn't seem to be blocking * arrayify(mark.data)?.length * facetData.length * revert wording Co-authored-by: Mike Bostock <[email protected]> Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.