Skip to content

add made by observable component#1736

Merged
mbostock merged 8 commits into
mainfrom
cobus/topnav
Oct 11, 2024
Merged

add made by observable component#1736
mbostock merged 8 commits into
mainfrom
cobus/topnav

Conversation

@CobusT
Copy link
Copy Markdown
Contributor

@CobusT CobusT commented Oct 10, 2024

Adds the Made by Observable button to the header of the site.

  • created a logo() function in the config file since the code was duplicated
  • desktop vs mobile classes to show different versions of the GitHub information
  • removed the toc z-index since it conflicts with the component's popover. It doesn't seem to be needed for the toc.

@CobusT CobusT requested a review from mbostock October 10, 2024 02:05
@mbostock mbostock enabled auto-merge (squash) October 11, 2024 04:23
@mbostock mbostock merged commit 63c63e8 into main Oct 11, 2024
@mbostock mbostock deleted the cobus/topnav branch October 11, 2024 04:26
Comment thread src/style/layout.css
position: fixed;
color: var(--theme-foreground-muted);
font: 400 14px var(--sans-serif);
z-index: 1;
Copy link
Copy Markdown
Member

@mbostock mbostock Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC links are currently not clickable without the z-index: 1 because they are obscured (invisibly) by the main column. We’ll need to fix this ASAP, perhaps by putting the observable-made-by within its own z-index container. Edit: Fixed in fa2b5b6.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbostock

mbostock added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants