fix(bug): create /usr/local/bin if not present #614
Conversation
…ix install script
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage ? 74.98%
=======================================
Files ? 133
Lines ? 10089
Branches ? 0
=======================================
Hits ? 7565
Misses ? 2054
Partials ? 470 Continue to review full report at Codecov.
|
|
Do we even want to put a link in this directory if it doesn't exist? I imagine this is to make it so that stanza is on your path, does creating the directory and linking actually do that on the affected systems? |
README.md
Outdated
| - Single command install, requires the `curl` command | ||
| - Stanza will automatically be running as a service | ||
| - On Linux, Stanza will be running as the `root` user. On Macos, Stanza will be running as your current user. | ||
| - `sudo` may be required if user running installer needs permission to write to installation locations and linking to `/usr/local/bin`. |
There was a problem hiding this comment.
Sudo is always required for Linux, and will be required for macos if the user does not have write permission to /usr/local/bin.
I agree with this generally, just am thinking about any current users that maybe built automation around expecting it being in |
schmikei
dismissed stale reviews from BinaryFissionGames and jsirianni
via
1ffe1d0
4 participants
Description of Changes
/usr/local/binpresent when they run the installer. So this PR addresses this by ensuring the directory exists before linking the installed binary to the $PATHTested on linux by removing the /usr/local/bin and rerunning the installer whereas on
mainit failed.From my understanding it is the responsibility of the third party app in the macOS ecosystem to create the folder if it wishes to add things to
/usr/local/binhttps://discussions.apple.com/thread/252495484Please check that the PR fulfills these requirements