Skip to content

Comments

deps(dependabot): Dependencies updates#599

Merged
cpheps merged 6 commits intomainfrom
dependabot-2022-03-08
Mar 8, 2022
Merged

deps(dependabot): Dependencies updates#599
cpheps merged 6 commits intomainfrom
dependabot-2022-03-08

Conversation

@cpheps
Copy link
Contributor

@cpheps cpheps commented Mar 8, 2022 •
edited
Loading

Description of Changes

Manually updated dependabot prs:

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@cpheps cpheps requested a review from a team as a code owner March 8, 2022 14:26
@cpheps cpheps requested a review from schmikei March 8, 2022 14:26
dehaansa
dehaansa previously approved these changes Mar 8, 2022
View reviewed changes
Corbin Phelps added 6 commits March 8, 2022 09:31
Updated aws-sdk-go to v1.43.13
d6bfa28 
Signed-off-by: Corbin Phelps <[email protected]>
Updated mapstructure to v1.4.3
d82541f 
Signed-off-by: Corbin Phelps <[email protected]>
Updated zap to v1.21.0
e03e336 
Signed-off-by: Corbin Phelps <[email protected]>
Updated cobra to v1.3.0
bacfa9c 
Signed-off-by: Corbin Phelps <[email protected]>
Updated google.golang.org/api to v0.70.0
f8bd632 
Signed-off-by: Corbin Phelps <[email protected]>
Updated internal tool dependencies
7fa0cf6 
Signed-off-by: Corbin Phelps <[email protected]>
@cpheps cpheps force-pushed the dependabot-2022-03-08 branch from 136d92d to 7fa0cf6 Compare March 8, 2022 14:31
@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@33707f8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage        ?   74.91%           
=======================================
  Files           ?      133           
  Lines           ?    10089           
  Branches        ?        0           
=======================================
  Hits            ?     7558           
  Misses          ?     2065           
  Partials        ?      466

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33707f8...7fa0cf6. Read the comment docs.

schmikei
schmikei reviewed Mar 8, 2022
View reviewed changes
Makefile
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec
Copy link
Contributor

@schmikei schmikei Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally a fan of pinning a version, now looking at this it seems like its kind of hodge-podge. Any strong reason why we are unpinning this here?

Copy link
Contributor

@schmikei schmikei Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh noticed the internal/tools/go.mod nvm

Copy link
Contributor Author

@cpheps cpheps Mar 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pinned in the go.mod file in internal tools

Copy link
Contributor Author

@cpheps cpheps Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yup I just noticed you figured out that. Resolving this.

schmikei
schmikei approved these changes Mar 8, 2022
View reviewed changes
Makefile
cd $(TOOLS_MOD_DIR) && go install github.com/observiq/amazon-log-agent-benchmark-tool/cmd/logbench
cd $(TOOLS_MOD_DIR) && go install github.com/goreleaser/goreleaser
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1
cd $(TOOLS_MOD_DIR) && go install github.com/securego/gosec/v2/cmd/gosec
Copy link
Contributor

@schmikei schmikei Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh noticed the internal/tools/go.mod nvm

@cpheps cpheps merged commit 93c9769 into main Mar 8, 2022
@cpheps cpheps deleted the dependabot-2022-03-08 branch March 8, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmikei schmikei schmikei approved these changes

+2 more reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@dehaansa dehaansa dehaansa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpheps @dehaansa @BinaryFissionGames @schmikei