doc: Proxy settings should use systemd override#595
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 76.69% 74.93% -1.76%
==========================================
Files 132 133 +1
Lines 8308 10086 +1778
==========================================
+ Hits 6371 7557 +1186
- Misses 1473 2058 +585
- Partials 464 471 +7
Continue to review full report at Codecov.
|
BinaryFissionGames
approved these changes
Mar 4, 2022
schmikei
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When enabling proxy, we should be using a systemd override instead of editing the main service file. This is because the package manager (rpm / deb) will replace the systemd service. Using an override allows the user to make changes without preventing us from making changes to the main service.
Please check that the PR fulfills these requirements