Skip to content

Comments

deps: Syslog version priority#593

Merged
armstrmi merged 2 commits intomasterfrom
syslog-version-priority
Mar 3, 2022
Merged

deps: Syslog version priority#593
armstrmi merged 2 commits intomasterfrom
syslog-version-priority

Conversation

@armstrmi
Copy link
Contributor

@armstrmi armstrmi commented Mar 2, 2022

Description of Changes

  • Added tests to verify that the Version and Priority fields of the syslog message now accept any integer value for their input

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@armstrmi armstrmi requested a review from a team as a code owner March 2, 2022 21:15
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #593 (8931dca) into master (3b23e5c) will decrease coverage by 1.70%.
The diff coverage is 88.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   76.69%   74.99%   -1.70%     
==========================================
  Files         132      133       +1     
  Lines        8308    10086    +1778     
==========================================
+ Hits         6371     7563    +1192     
- Misses       1473     2053     +580     
- Partials      464      470       +6
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cec988...8931dca. Read the comment docs.

schmikei
schmikei approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BinaryFissionGames BinaryFissionGames changed the title dep: Syslog version priority deps: Syslog version priority Mar 2, 2022
@armstrmi armstrmi merged commit efa4544 into master Mar 3, 2022
@armstrmi armstrmi deleted the syslog-version-priority branch March 3, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmikei schmikei schmikei approved these changes

@jmwilliams89 jmwilliams89 Awaiting requested review from jmwilliams89

+1 more reviewer

@cpheps cpheps cpheps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armstrmi @cpheps @schmikei