Skip to content

Comments

fix: Goreleaser fixes#591

Merged
BinaryFissionGames merged 3 commits intomasterfrom
goreleaser-fixes
Mar 2, 2022
Merged

fix: Goreleaser fixes#591
BinaryFissionGames merged 3 commits intomasterfrom
goreleaser-fixes

Conversation

@BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Feb 28, 2022

Description of Changes

  • Fix goreleaser attaching binaries to the release with incorrect naming convention
  • Fix goreleaser not attaching scripts + plugins to release
    • This resulted in removing the post-build script.
  • Change script to suffix windows binary with ".exe" for future releases (releases after 1.6.0)
    • This is kinda messy and I'd prefer to just keep the name of the binary as it was (no .exe), but unfortunately goreleaser hard-codes the .exe suffix for windows binaries.
    • I have tested this script to ensure it generates the correct download URL for previous and future releases when specifying the --version flag.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner February 28, 2022 20:34
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #591 (e3f24a9) into master (3b23e5c) will decrease coverage by 1.71%.
The diff coverage is 87.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   76.69%   74.98%   -1.71%     
==========================================
  Files         132      133       +1     
  Lines        8308    10086    +1778     
==========================================
+ Hits         6371     7562    +1191     
- Misses       1473     2059     +586     
- Partials      464      465       +1
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d1d31...e3f24a9. Read the comment docs.

cpheps
cpheps previously approved these changes Mar 1, 2022
View reviewed changes
@BinaryFissionGames BinaryFissionGames mentioned this pull request Mar 2, 2022
Merged
3 tasks
jsirianni
jsirianni requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to the post script

tar -xf ./artifacts/stanza-plugins.tar.gz -C ./artifacts

Which will be removed here. My package PR depends on artifacts/plugins being present. Can we add that here?

@BinaryFissionGames
Copy link
Contributor Author

BinaryFissionGames commented Mar 2, 2022

Once the package PR is merged, I'll rebase and take that into account.

@jsirianni
Copy link
Member

jsirianni commented Mar 2, 2022

Once the package PR is merged, I'll rebase and take that into account.

Merged 👍

@BinaryFissionGames BinaryFissionGames merged commit 9cec988 into master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsirianni jsirianni jsirianni approved these changes

+1 more reviewer

@cpheps cpheps cpheps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BinaryFissionGames @jsirianni @cpheps