Skip to content

Comments

Added goreleaser changelog groups and update PR template#580

Merged
cpheps merged 5 commits intomasterfrom
goreleaser-changelog
Feb 28, 2022
Merged

Added goreleaser changelog groups and update PR template#580
cpheps merged 5 commits intomasterfrom
goreleaser-changelog

Conversation

@cpheps
Copy link
Contributor

@cpheps cpheps commented Feb 28, 2022

Description of Changes

  • Updated goreleaser with changelog groups
  • Updated PR template to include instructions and remove changelog checkbox.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@cpheps cpheps requested a review from a team as a code owner February 28, 2022 15:28
@cpheps cpheps requested a review from armstrmi February 28, 2022 15:28
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #580 (25309b2) into master (3b23e5c) will decrease coverage by 1.79%.
The diff coverage is 86.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   76.69%   74.90%   -1.79%     
==========================================
  Files         132      133       +1     
  Lines        8308    10079    +1771     
==========================================
+ Hits         6371     7549    +1178     
- Misses       1473     2064     +591     
- Partials      464      466       +2
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5080693...25309b2. Read the comment docs.

BinaryFissionGames
BinaryFissionGames previously approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's our plan with the changelog file? Seems redundant.

@cpheps
Copy link
Contributor Author

cpheps commented Feb 28, 2022

What's our plan with the changelog file? Seems redundant.

I agree. Probably add a big deprecated note at the top but keep it to preserve history.

Mrod1598
Mrod1598 reviewed Feb 28, 2022
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated
- `fix(OPTIONAL):` = Bug fixes
- `deps(OPTIONAL):` = Dependency updates, primarily dependabot

_Delete the above paragraph before submitting._
Copy link
Contributor

@Mrod1598 Mrod1598 Feb 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also, have the above just be a comment so then it really doesn't matter. What's meant to be in the parenthese?

Copy link
Contributor Author

@cpheps cpheps Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll do that.

Anything you want can go in the parenthesis or just ignore them all together.

@jsirianni
Copy link
Member

jsirianni commented Feb 28, 2022

I forgot to mention, Dependabot can be told how it should name and label pull requests https://github.com/observIQ/iris/pull/209/files

@cpheps
Copy link
Contributor Author

cpheps commented Feb 28, 2022

I forgot to mention, Dependabot can be told how it should name and label pull requests https://github.com/observIQ/iris/pull/209/files

I didn't know that I'll update.

@cpheps
Copy link
Contributor Author

cpheps commented Feb 28, 2022

CI failures are unrelated to changes going to merge.

@cpheps cpheps merged commit 6410e79 into master Feb 28, 2022
@cpheps cpheps deleted the goreleaser-changelog branch February 28, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armstrmi armstrmi Awaiting requested review from armstrmi armstrmi was automatically assigned from observIQ/ot-pipeline-team

2 more reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@Mrod1598 Mrod1598 Mrod1598 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpheps @jsirianni @BinaryFissionGames @Mrod1598