Skip to content

Comments

Add ability to create slice in plugin#573

Merged
Mrod1598 merged 4 commits intomasterfrom
add-default-strings-support
Feb 24, 2022
Merged

Add ability to create slice in plugin#573
Mrod1598 merged 4 commits intomasterfrom
add-default-strings-support

Conversation

@Mrod1598
Copy link
Contributor

@Mrod1598 Mrod1598 commented Feb 24, 2022 •
edited
Loading

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@Mrod1598 Mrod1598 requested a review from a team as a code owner February 24, 2022 17:30
@Mrod1598 Mrod1598 requested a review from cpheps February 24, 2022 17:30
cpheps
cpheps suggested changes Feb 24, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #573 (a017bef) into master (3b23e5c) will decrease coverage by 1.73%.
The diff coverage is 86.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   76.69%   74.96%   -1.73%     
==========================================
  Files         132      133       +1     
  Lines        8308    10079    +1771     
==========================================
+ Hits         6371     7555    +1184     
- Misses       1473     2059     +586     
- Partials      464      465       +1
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd85d9...a017bef. Read the comment docs.

cpheps
cpheps approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mrod1598 Mrod1598 merged commit c100556 into master Feb 24, 2022
@Mrod1598 Mrod1598 deleted the add-default-strings-support branch February 24, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@cpheps cpheps cpheps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mrod1598 @BinaryFissionGames @cpheps