Conversation
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 76.69% 74.88% -1.80%
==========================================
Files 132 133 +1
Lines 8308 10076 +1768
==========================================
+ Hits 6371 7545 +1174
- Misses 1473 2065 +592
- Partials 464 466 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
May look into adding https://pkg.go.dev/expvar as another flag and thats what we publish. Not sure if its necessary on this first pass. |
cpheps
reviewed
Feb 23, 2022
Contributor
cpheps
left a comment
cpheps
left a comment
There was a problem hiding this comment.
Overall looks good just come comments
cpheps
reviewed
Feb 23, 2022
cpheps
previously approved these changes
Feb 23, 2022
Mrod1598
reviewed
Feb 23, 2022
Mrod1598
previously approved these changes
Feb 23, 2022
BinaryFissionGames
approved these changes
Feb 23, 2022
cpheps
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a new output operator:
count_outputThe purpose of this operator is to count the number of entries processed over an interval.
Proposed config:
Please check that the PR fulfills these requirements