Skip to content

Comments

Build and Test Windows MSI during release#569

Merged
jsirianni merged 60 commits intomasterfrom
windows-msi
Mar 1, 2022
Merged

Build and Test Windows MSI during release#569
jsirianni merged 60 commits intomasterfrom
windows-msi

Conversation

@jsirianni
Copy link
Member

@jsirianni jsirianni commented Feb 21, 2022 •
edited
Loading

Description of Changes

Implemented MSI building. The MSI package can be used to install, repair, and uninstall stanza.

Codebase Changes

  • Added optional environment variables for log file path and database file path. This is because go-msi does not handle arguments very well when the path has spaces in it. Quoting should work but I get a strange wix error. Instead, I use environment variables to enable the log and database files.

Build Changes

  • Added make targets for using vagrant to build an MSI package.
  • Modified the release workflow to run on PR.
  • Added condition to release workflow "release" and "build container" stages to ensure they only run on a tagged release.
  • Added MSI building to release workflow, it will run on PR and pushed tag. The release stage will wait for the msi build, and then download the msi artifcats and bundle it with the Goreleaser release.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@codecov
Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #569 (3bca623) into master (3b23e5c) will decrease coverage by 1.71%.
The diff coverage is 87.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   76.69%   74.98%   -1.71%     
==========================================
  Files         132      133       +1     
  Lines        8308    10086    +1778     
==========================================
+ Hits         6371     7562    +1191     
- Misses       1473     2059     +586     
- Partials      464      465       +1
Impacted Files Coverage Δ
operator/buffer/buffer.go 75.86% <ø> (-1.92%) ⬇️
operator/buffer/memory.go 71.60% <ø> (-3.74%) ⬇️
...builtin/input/aws/cloudwatch/cloudwatch_persist.go 75.00% <ø> (-6.82%) ⬇️
operator/builtin/input/azure/event_hub.go 0.00% <0.00%> (ø)
operator/builtin/input/azure/event_hub_config.go 90.91% <ø> (-1.09%) ⬇️
operator/builtin/input/file/finder.go 100.00% <ø> (ø)
operator/builtin/input/file/reader.go 53.05% <0.00%> (-5.73%) ⬇️
operator/builtin/input/http/config.go 97.56% <ø> (-0.29%) ⬇️
operator/builtin/input/journald/journald.go 58.76% <ø> (-1.83%) ⬇️
operator/builtin/input/udp/udp.go 73.49% <ø> (-1.51%) ⬇️
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6410e79...3bca623. Read the comment docs.

jsirianni and others added 26 commits February 21, 2022 13:57
Refactor
49dfabc
checkout master branch for now
f279a84
use curl instead of wget
0643144
remove quote
32342bc
try setting path by modifying the GITHUB_PATH
badb9e6
copy plugins to msi build dir
11fb2c1
try tr instead of sed
9dadd3e
clone plugins to stanza-plugins directory
1534ccc
refactor plugin clone logic
6c79884
set env variable the windows way
1ab84b8
@jsirianni
Merge branch 'master' into windows-msi
6bcf8bf
@jsirianni
set action output
8efd24c
@jsirianni
use correct output
35dd79b
@jsirianni
dont use multi line
6ad08d6
@jsirianni
copy binary to msi build dir
a1cc1f4
@jsirianni
try installing tools to windows/build
b309347
@jsirianni
try building msi from C drive
9bc55aa
@jsirianni
fix work dir
3ecd87c
@jsirianni
everything is working. add new build dir to path
108bd0b
@jsirianni
run cinc installer
bdb5557
@jsirianni
test upload
c130c4d
@jsirianni
fix cinc installer name
80f41c3
fix source binary name
e5f6202
rename inspec.rb --> install.rb
11ff5a3
install tools after copying build dir
b592511
add uninstall tests
4625a91
@jsirianni jsirianni marked this pull request as ready for review February 22, 2022 18:37
@jsirianni jsirianni requested a review from a team as a code owner February 22, 2022 18:37
@cpheps cpheps self-requested a review February 23, 2022 13:17
cpheps
cpheps reviewed Feb 23, 2022
View reviewed changes
@jsirianni jsirianni requested a review from cpheps February 23, 2022 16:01
cpheps
cpheps previously approved these changes Feb 25, 2022
View reviewed changes
BinaryFissionGames
BinaryFissionGames reviewed Feb 28, 2022
View reviewed changes
@jsirianni jsirianni changed the title Build and Test Windows MSI Build and Test Windows MSI during release Feb 28, 2022
@jsirianni jsirianni merged commit a5b004b into master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@cpheps cpheps cpheps approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsirianni @BinaryFissionGames @cpheps