Skip to content

Comments

GitHub Action CI/CD Migration#553

Merged
cpheps merged 5 commits intomasterfrom
github-actions
Feb 16, 2022
Merged

GitHub Action CI/CD Migration#553
cpheps merged 5 commits intomasterfrom
github-actions

Conversation

@cpheps
Copy link
Contributor

@cpheps cpheps commented Feb 16, 2022

Description of Changes

  • Migrated Build, Release, and Test CI/CD to Github Action
  • Temporarily removed benchmark reporting and runs on CI. Will revisit later once we have a more reliable system.

Will turn off circle once this is merged.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@cpheps cpheps requested a review from jsirianni February 16, 2022 15:31
@cpheps
Copy link
Contributor Author

cpheps commented Feb 16, 2022

Investigating CI/CD Issues

Corbin Phelps added 2 commits February 16, 2022 10:36
Signed-off-by: Corbin Phelps <[email protected]>
jsirianni
jsirianni previously approved these changes Feb 16, 2022
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I had a comment on caching. It could help speed up the build.

Signed-off-by: Corbin Phelps <[email protected]>
@jsirianni jsirianni self-requested a review February 16, 2022 18:22
@cpheps cpheps merged commit 55abccb into master Feb 16, 2022
@cpheps cpheps deleted the github-actions branch February 16, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants