Skip to content

Comments

[WIP] feat: add ShiftJIS to supported encodings#546

Merged
cpheps merged 1 commit intoobservIQ:masterfrom
pea723:feat/encoding-shift-jis
Feb 15, 2022
Merged

[WIP] feat: add ShiftJIS to supported encodings#546
cpheps merged 1 commit intoobservIQ:masterfrom
pea723:feat/encoding-shift-jis

Conversation

@pea723
Copy link
Contributor

@pea723 pea723 commented Feb 15, 2022

Description of Changes

Add ShiftJIS (Japanese major encoding) to supported encodings.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@cpheps cpheps self-requested a review February 15, 2022 12:59
@cpheps
Copy link
Contributor

cpheps commented Feb 15, 2022

CI Failures are unreleated to this PR.

Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpheps cpheps merged commit 3b23e5c into observIQ:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants