Skip to content

Comments

Add Proxy Support to Unix Install Script#515

Merged
schmikei merged 7 commits intomasterfrom
proxy-installer
Jan 3, 2022
Merged

Add Proxy Support to Unix Install Script#515
schmikei merged 7 commits intomasterfrom
proxy-installer

Conversation

@schmikei
Copy link
Contributor

@schmikei schmikei commented Dec 29, 2021

Description of Changes

Adds flags to the installer script

    -x, --proxy
        Defines the proxy server to be used for communication by the install script.
        Example: -x http(s)://server-ip:port/.

    -U, --proxy-user
        Defines the proxy user to be used for communication by the install script.

    -P, --proxy-password
        Defines the proxy password to be used for communication by the install script.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Contributor

djaglowski commented Dec 29, 2021

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6896461 -0.10351205 128.58633 -0.60588074
1 5000 5.96555 -0.22419643 137.22495 -0.3152008
1 10000 11.017305 -0.74163723 143.51643 -5.091461
1 50000 64.8459 +0.19018555 170.40355 -9.0784
1 100000 132.30176 +0.47203064 221.2597 -9.964844
10 100 2.1552083 -0.017205715 132.0198 -0.9924469
10 500 6.982816 -0.655272 138.3129 -0.36880493
10 1000 13.327756 -0.20698738 146.12352 -1.2206268
10 5000 68.62156 +2.0688324 173.36772 -4.232895
10 10000 126.41905 -6.7586517 226.74866 -1.9543304

@codecov
Copy link

codecov bot commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #515 (63a4c7b) into master (3140581) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head 63a4c7b differs from pull request most recent head 08f032f. Consider uploading reports for the commit 08f032f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   76.43%   76.64%   +0.21%     
==========================================
  Files         132      132              
  Lines        8290     8301      +11     
==========================================
+ Hits         6336     6362      +26     
+ Misses       1482     1469      -13     
+ Partials      472      470       -2
Impacted Files Coverage Δ
operator/builtin/output/googlecloud/entry.go 100.00% <100.00%> (ø)
operator/builtin/output/googlecloud/proto.go 100.00% <100.00%> (+13.98%) ⬆️
operator/builtin/input/journald/journald.go 60.58% <0.00%> (-1.46%) ⬇️
operator/builtin/output/forward/forward.go 61.73% <0.00%> (+1.23%) ⬆️
operator/builtin/input/file/file.go 78.68% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7754ef...08f032f. Read the comment docs.

@schmikei schmikei requested a review from jsirianni December 30, 2021 14:30
@djaglowski
Copy link
Contributor

djaglowski commented Dec 30, 2021

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6207188 -0.17243934 128.33418 -0.8580322
1 5000 6.310548 +0.12080145 136.86086 -0.6792908
1 10000 12.569058 +0.8101158 148.54324 -0.06465149
1 50000 63.535824 -1.1198921 176.35667 -3.1252747
1 100000 124.91839 -6.911339 224.70743 -6.5171204
10 100 2.034459 -0.13795495 132.03624 -0.9760132
10 500 7.1553073 -0.48278093 139.78853 +1.1068268
10 1000 13.241616 -0.29312706 146.12257 -1.2215729
10 5000 58.640026 -7.9127007 174.43777 -3.1628418
10 10000 130.09698 -3.080719 237.87204 +9.169052

jsirianni
jsirianni requested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this docker command to run a proxy locally

docker run \
  -p 3128:3128 \
  bmedora/squid:0.1.2 \
  /apps/squid/sbin/squid -NsY -f /apps/squid.conf.basicauth

scripts/unix-install.sh --proxy localhost:3128 --proxy-user user1 --proxy-password user1

@djaglowski
Copy link
Contributor

djaglowski commented Dec 30, 2021

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.655216 -0.1379422 131.1584 +1.9661865
1 5000 5.637965 -0.5517812 135.01495 -2.5251923
1 10000 11.775937 +0.016994476 148.0058 -0.60209656
1 50000 60.19091 -4.4648056 172.77762 -6.7043304
1 100000 137.15738 +5.327652 235.99596 +4.771408
10 100 2.017221 -0.15519309 132.83647 -0.17578125
10 500 7.207092 -0.43099642 139.78004 +1.0983429
10 1000 13.017385 -0.5173588 146.62096 -0.7231903
10 5000 68.25973 +1.7070007 180.55226 +2.951645
10 10000 144.79688 +11.619171 234.81493 +6.1119385

@schmikei schmikei requested a review from jsirianni December 30, 2021 18:50
@schmikei schmikei changed the title Add Proxy Support to Install Script Add Proxy Support to Unix Install Script Jan 3, 2022
@schmikei schmikei merged commit e418a18 into master Jan 3, 2022
@schmikei schmikei deleted the proxy-installer branch January 3, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsirianni jsirianni jsirianni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmikei @djaglowski @jsirianni