[Bug] Fix outscrapper map review API along with moving to faster V3 API#250
Merged
lalitpagaria merged 4 commits intomasterfrom Jul 12, 2022
Merged
[Bug] Fix outscrapper map review API along with moving to faster V3 API#250lalitpagaria merged 4 commits intomasterfrom
lalitpagaria merged 4 commits intomasterfrom
Conversation
GirishPatel
reviewed
Jul 11, 2022
| 'sort': config.sort, | ||
| 'start': since_timestamp, | ||
| 'cutoff': config.until_timestamp, | ||
| 'cutoff': since_timestamp, |
Collaborator
There was a problem hiding this comment.
This doesn't look right.
Collaborator
Author
There was a problem hiding this comment.
still working on it. Unable to test locally hence pushing to git and then test on colan
Collaborator
There was a problem hiding this comment.
Okay, cool !
I thought, it's open for review.
Collaborator
Author
|
@GirishPatel Please review now |
GirishPatel
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.