Updated the README#222
Merged
lalitpagaria merged 5 commits intoobsei:masterfrom Jan 21, 2022
0xku:updated-docs
Merged
Conversation
|
|
Collaborator
|
@kuutsav Thank you for working on it. |
Collaborator
|
Kindly create separate PR for black formatting-related changes, as it would be easier to review. |
This reverts commit 5fbf7a8.
Contributor
Author
Reverted two commits. This PR just contains the updates to the README now. |
lalitpagaria
approved these changes
Jan 21, 2022
Collaborator
lalitpagaria
left a comment
lalitpagaria
left a comment
There was a problem hiding this comment.
Thanks, @kuutsav for fixing Readme.
I have one comment, the rest all is fine.
README.md
Outdated
Comment on lines
+801
to
+806
| # For custom domain refer http://docs.facetoe.com.au/zenpy.html#custom-domains | ||
| # Mainly you can do this by setting the environment variables: | ||
| # ZENPY_FORCE_NETLOC | ||
| # ZENPY_FORCE_SCHEME (default to https) | ||
| # when set it will force request on: | ||
| # {scheme}://{netloc}/endpoint |
Collaborator
There was a problem hiding this comment.
These lines are stale now, I forgot to remove it in #221
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a broken importQuite a few pre-commit changes made by black