spacy ner analyzer , #165 enhancement#171
Merged
lalitpagaria merged 4 commits intoobsei:masterfrom Jul 22, 2021
Merged
Conversation
Contributor
Author
|
please add these spacy models on the server this testing is taking place : "en_core_web_sm" , "en_core_web_trf"
|
Collaborator
|
Can you please add required download at line no 63 |
lalitpagaria
requested changes
Jul 20, 2021
Collaborator
lalitpagaria
left a comment
lalitpagaria
left a comment
There was a problem hiding this comment.
@akar5h Thanks for this PR.
Overall it is good. I have few comments, can you please address them post that we can merge it.
Contributor
Author
|
@lalitpagaria I have addressed most of the issues. Pls hv a look |
lalitpagaria
approved these changes
Jul 22, 2021
Collaborator
lalitpagaria
left a comment
lalitpagaria
left a comment
There was a problem hiding this comment.
LGTM!
Thanks @akar5h for working on it
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
have a look when its convinient.
Implemented
SpacyNerAnalyzerand renamedNerAnalyzertoTransformerNerAnalyzer. Also updated the tests ,|