TextSplitter Preprocessor Pipeline#160
Merged
lalitpagaria merged 5 commits intoobsei:masterfrom Jul 7, 2021
Merged
Conversation
lalitpagaria
reviewed
Jul 7, 2021
lalitpagaria
requested changes
Jul 7, 2021
Collaborator
lalitpagaria
left a comment
lalitpagaria
left a comment
There was a problem hiding this comment.
@akar5h Thank you for working on it. It is really nice design. I only have one comment, please address it then I will merge it.
akar5h
commented
Jul 7, 2021
lalitpagaria
reviewed
Jul 7, 2021
lalitpagaria
reviewed
Jul 7, 2021
lalitpagaria
approved these changes
Jul 7, 2021
Collaborator
lalitpagaria
left a comment
lalitpagaria
left a comment
There was a problem hiding this comment.
LGTM!
@akar5h Thank you for working on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lalitpagaria as per or discussion on #153 , I have created a TextSplitter as a Preprocessing node, Kindly have a look and comment if any other changes required .