Skip to content

Email source fixed, no duplicates in each iteration#158

Merged
lalitpagaria merged 1 commit intoobsei:masterfrom
namanjuneja771:naman
Jul 6, 2021
Merged

Email source fixed, no duplicates in each iteration#158
lalitpagaria merged 1 commit intoobsei:masterfrom
namanjuneja771:naman

Conversation

@namanjuneja771
Copy link
Copy Markdown
Contributor

One mail was repeated in each iteration previously which has been removed now.

@lalitpagaria lalitpagaria requested a review from GirishPatel July 5, 2021 03:56
@lalitpagaria
Copy link
Copy Markdown
Collaborator

Thank you @namanjuneja771 for working on it. @GirishPatel will review it.

Just more context for @GirishPatel

  • Using.Email source with state giving 1 duplicate email on each run. Which we suspect due to incorrect loop condition. @namanjuneja771 with his PR fixing that bug.

Copy link
Copy Markdown
Collaborator

@GirishPatel GirishPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitpagaria
Copy link
Copy Markdown
Collaborator

@namanjuneja771 Thank you very much for fixing the bug.

@lalitpagaria lalitpagaria merged commit 70c8d4a into obsei:master Jul 6, 2021
@lalitpagaria lalitpagaria added the bug Something isn't working label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants