Release 9.1.0 #673
Merged
Release 9.1.0 #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joarkosberg
reviewed
Nov 11, 2024
| * @platform iOS, visionOS | ||
| * @default AUTHENTICATION_TYPE.DEVICE_PASSCODE_OR_BIOMETRICS | ||
| */ | ||
| authenticationType?: AUTHENTICATION_TYPE; |
There was a problem hiding this comment.
A question, I see authenticationType parameter is not part of SetOptions or GetOptions. Starting seeing type error after updating to 9.1.0 and updating types.
Should it still be in those types or does the option dont provide anything for set/get password?
Collaborator
Author
There was a problem hiding this comment.
@joarkosberg Yes, that's right. The types and methods in this project were quite messy, so I tried to tidy them up a bit. The authenticationType is only needed and used in the canCheckAuthentication method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.