Fix install script failing when version cannot be determined (#772) #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #772 The install script was failing with "Checksums do not match" when the GitHub API rate limit was hit or network issues prevented retrieving the latest release version. Changes: - Add validation to check if version is empty before proceeding - Provide helpful error message explaining the issue - Suggest workaround using manual version specification - Remove redundant get_checksum_url call - Add missing ;; in get_machine function for consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 246 246
Lines 12140 12140
=======================================
Hits 10770 10770
Misses 931 931
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reuvenharrison
deleted the
772-installation-script-of-the-plugin-on-linux-doesnt-work-anymore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
The install script was failing with "Checksums do not match" when the GitHub API rate limit was hit or network issues prevented retrieving the latest release version.
Changes:
🤖 Generated with Claude Code